Android: add raw key event support for terminal compatibility by SashankBhamidi · Pull Request #272 · bk138/multivnc

SashankBhamidi · 2025-09-14T22:03:00Z

Summary

Implements QEMU Extended Key Event protocol support for Android client to address raw key event handling issues, particularly for terminal applications like Termux.

Adds Android toggle for enabling raw key events when VNC server supports it
Complete XT keycode mapping system for Android KeyEvent codes
JNI integration for QEMU Extended Key Events via LibVNCClient
Server capability detection with graceful fallback to standard key events
Support for critical keys: AltGr, Ctrl+Alt+Del, F1-F12, arrow keys, modifiers

Test Results

All 17 unit tests pass (AndroidKeyToXtTest)
Java/Kotlin compilation successful
Android lint clean for implementation files
Follows project coding conventions and contributing guidelines

Technical Details

Uses existing LibVNCClient SendExtendedKeyEvent API (available since 2020). No submodule changes required. Maintains backward compatibility with default setting disabled.

Addresses issue #214.

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

#214: Sending Raw Keys

Neustradamus · 2025-09-15T11:11:34Z

@SashankBhamidi: Nice, thanks!

SashankBhamidi · 2025-09-15T11:42:30Z

Lmk if changes needed, will ship as required!

bk138

pretty neat, some minor comments! thanks for the contribution! ❤️

android/app/src/main/java/com/coboltforge/dontmind/multivnc/AndroidKeyToXt.kt

android/app/src/main/java/com/coboltforge/dontmind/multivnc/VNCConn.java

android/app/src/main/java/com/coboltforge/dontmind/multivnc/db/ConnectionBean.kt

android/app/src/main/res/values/strings.xml

android/app/src/test/java/com/coboltforge/dontmind/multivnc/AndroidKeyToXtTest.java

android/app/build.gradle

bk138

some minor requests...

- Add XT scan code specification link to documentation - Move hasXtMapping() helper method from production code to test file - Extend existing OutputEvent constructor instead of adding second one - Bump database version to 16 with migration for sendRawKeys column - Add translations for all supported languages (ca, de, es, gl, it, ja, pt, ru, uk, zh, zh-rTW) Addresses review comments from PR bk138#272.

SashankBhamidi · 2025-09-21T17:37:11Z

@bk138 Addressed 5/8 suggestions. Implemented: XT spec link, moved hasXtMapping() to tests, extended constructor, database version bump, and added translations. Kept unit tests for validation and current int pattern for consistency.

SashankBhamidi · 2025-09-21T17:46:20Z

Quick note on translations: These were AI-generated per your suggestion. I don't speak all these languages, I do not guarantee their accuracy.

android/app/src/main/java/com/coboltforge/dontmind/multivnc/AndroidKeyToXt.kt

android/app/src/main/java/com/coboltforge/dontmind/multivnc/VNCConn.java

android/app/src/main/java/com/coboltforge/dontmind/multivnc/db/VncDatabase.java

- Replace int xtKeycode with OptionalInt for cleaner code semantics - Remove AndroidKeyToXtTest.java and related test dependencies - Update all xtKeycode usage to use OptionalInt.isPresent()/getAsInt() - Compilation verified successful Addresses final review feedback from PR bk138#272.

SashankBhamidi · 2025-09-22T15:37:00Z

@bk138 Changes complete! OptionalInt implemented and tests removed as requested. Ready for review, thanks for the feedback!

SashankBhamidi · 2025-09-23T05:20:41Z

@Iey4iej3 @bk138 Once this is merged, could either one of you accept my PR on IssueHunt so the funds get released to me by rewarding my PR (the issue must not be closed before rewarding)? Thanks!

https://oss.issuehunt.io/r/bk138/multivnc/issues/214

android/app/src/main/java/com/coboltforge/dontmind/multivnc/VNCConn.java

android/app/src/main/java/com/coboltforge/dontmind/multivnc/db/VncDatabase.java

bk138 · 2025-09-23T12:21:32Z

@SashankBhamidi almost there! Thanks for your patience!

- Change database migration to use BOOLEAN instead of INTEGER for sendRawKeys - Remove useExtended field, use only OptionalInt.isPresent() for cleaner design - Add authoritative specification links: RFC 6143 for RFB protocol and vncdotool for QEMU Extended Key Event protocol - Simplify OutputEvent constructor by removing useExtended parameter All changes compile successfully. Addresses final review comments from PR bk138#272.

SashankBhamidi · 2025-09-23T13:18:38Z

@Iey4iej3 @bk138 Once this is merged, could either one of you accept my PR on IssueHunt so the funds get released to me by rewarding my PR (the issue must not be closed before rewarding)? Thanks!

https://oss.issuehunt.io/r/bk138/multivnc/issues/214

Since merging this PR will automatically close the issue, I think it’s better to reward the PR on IssueHunt before merging.

bk138 · 2025-09-24T06:33:21Z

Rewarded https://oss.issuehunt.io/r/bk138/multivnc/issues/214
Added some changes to your PR @SashankBhamidi, will merge from my local branch.

SashankBhamidi · 2025-09-24T08:03:45Z

Added some changes to your PR @SashankBhamidi, will merge from my local branch.

@bk138, I thought you were going to merge this PR along with your commits. Closing instead of merging affects my GitHub stats.

bk138 · 2025-09-24T08:08:29Z

@SashankBhamidi Sorry. I don't know how to put commits into your branch/PR other than doing that locally. Do you have docs/info on that for next time?

SashankBhamidi · 2025-09-24T09:00:40Z

@SashankBhamidi Sorry. I don't know how to put commits into your branch/PR other than doing that locally. Do you have docs/info on that for next time?

For future reference, you can push to contributor branches:

git remote add contributor https://github.com/SashankBhamidi/multivnc.git
git push contributor master:feature/android-raw-keys-214

Then merge the updated PR normally.

Docs: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/about-permissions-and-visibility-of-forks

SashankBhamidi · 2025-09-24T09:07:17Z

@bk138 Could you reopen and merge PR #272? I've force pushed an empty commit so this PR can get merged. "Merged" vs "Closed" status is important for my GitHub contribution stats since I use them for freelancing gigs.

Note: Merging this empty PR won't modify any files since all the actual changes are already in master - this is just to fix the PR status from "Closed" to "Merged".

bk138 · 2025-09-24T11:01:45Z

@SashankBhamidi get your point. There are merge conflicts now, maybe add a single new commit improving some indentation or the like.

SashankBhamidi · 2025-09-24T11:05:22Z

@bk138, my bad, forgot to reset with upstream before pushing an empty commit. Ready for merge.

SashankBhamidi · 2025-09-24T13:23:47Z

Thanks! Will get to issue #216 shortly.

Neustradamus · 2025-09-24T19:06:40Z

@SashankBhamidi: Good job, thanks!

SashankBhamidi · 2025-09-28T11:46:35Z

Rewarded https://oss.issuehunt.io/r/bk138/multivnc/issues/214

@bk138 mind if I ask you about the steps you used to reward me? I’m running into an issue with another bounty where my PR isn’t being rewarded, and I’m not too familiar with the process. If you could walk me through it quickly, I’d really appreciate it!

Reference: OpenRefine/OpenRefine#7432 (comment)

bk138 · 2025-09-28T17:19:27Z

Rewarded https://oss.issuehunt.io/r/bk138/multivnc/issues/214

@bk138 mind if I ask you about the steps you used to reward me? I’m running into an issue with another bounty where my PR isn’t being rewarded, and I’m not too familiar with the process. If you could walk me through it quickly, I’d really appreciate it!

Reference: OpenRefine/OpenRefine#7432 (comment)

The issuehunt page shows funded issues per project, once there is a PR a "reward" button appears, this is how i did it for this issue. It can be that projects need to be added to issuehunt by the maintainer manually; there is an "Add Repository" button in the upper right.

SashankBhamidi mentioned this pull request Sep 14, 2025

Sending Raw Keys #214

Closed

bk138 self-assigned this Sep 18, 2025

bk138 approved these changes Sep 18, 2025

View reviewed changes

bk138 requested changes Sep 18, 2025

View reviewed changes

bk138 linked an issue Sep 18, 2025 that may be closed by this pull request

Sending Raw Keys #214

Closed

SashankBhamidi requested a review from bk138 September 21, 2025 17:49

bk138 requested changes Sep 22, 2025

View reviewed changes

SashankBhamidi requested a review from bk138 September 22, 2025 15:37

bk138 requested changes Sep 23, 2025

View reviewed changes

android/app/src/main/java/com/coboltforge/dontmind/multivnc/VNCConn.java Outdated Show resolved Hide resolved

android/app/src/main/java/com/coboltforge/dontmind/multivnc/db/VncDatabase.java Outdated Show resolved Hide resolved

SashankBhamidi requested a review from bk138 September 23, 2025 13:16

bk138 closed this in efe1e2d Sep 24, 2025

bk138 reopened this Sep 24, 2025

Android: trigger PR reopen for proper merge status

6165281

SashankBhamidi force-pushed the feature/android-raw-keys-214 branch from d808706 to 6165281 Compare September 24, 2025 11:04

bk138 merged commit 782190c into bk138:master Sep 24, 2025
2 of 3 checks passed

SashankBhamidi deleted the feature/android-raw-keys-214 branch September 24, 2025 13:23

Uh oh!

Conversation

SashankBhamidi commented Sep 14, 2025 • edited by issuehunt-oss bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Results

Technical Details

Referenced issues

Uh oh!

Neustradamus commented Sep 15, 2025

Uh oh!

SashankBhamidi commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bk138 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bk138 left a comment

Choose a reason for hiding this comment

Uh oh!

SashankBhamidi commented Sep 21, 2025

Uh oh!

SashankBhamidi commented Sep 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SashankBhamidi commented Sep 22, 2025

Uh oh!

SashankBhamidi commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bk138 commented Sep 23, 2025

Uh oh!

SashankBhamidi commented Sep 23, 2025

Uh oh!

bk138 commented Sep 24, 2025

Uh oh!

SashankBhamidi commented Sep 24, 2025

Uh oh!

bk138 commented Sep 24, 2025

Uh oh!

SashankBhamidi commented Sep 24, 2025

Uh oh!

SashankBhamidi commented Sep 24, 2025

Uh oh!

bk138 commented Sep 24, 2025

Uh oh!

SashankBhamidi commented Sep 24, 2025

Uh oh!

Uh oh!

SashankBhamidi commented Sep 24, 2025

Uh oh!

Neustradamus commented Sep 24, 2025

Uh oh!

SashankBhamidi commented Sep 28, 2025

Uh oh!

bk138 commented Sep 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

SashankBhamidi commented Sep 14, 2025 •

edited by issuehunt-oss bot

Loading

SashankBhamidi commented Sep 15, 2025 •

edited

Loading

SashankBhamidi commented Sep 21, 2025 •

edited

Loading

SashankBhamidi commented Sep 23, 2025 •

edited

Loading