Makefile wholearchive responsefile support#457
Closed
KageKirin wants to merge 7 commits intobkaradzic:masterfrom
Closed
Makefile wholearchive responsefile support#457KageKirin wants to merge 7 commits intobkaradzic:masterfrom
KageKirin wants to merge 7 commits intobkaradzic:masterfrom
Conversation
This fixes issues with many objects yielding a command line too long.
KageKirin
force-pushed
the
makefile-wholearchive-attfile
branch
from
6f7da42 to
1221704
Compare
Contributor
Author
|
closed PR b/c I ran into some issues. Will reopen after fixing them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
this is the PR for the follow up changes to #456 I mentioned in the latter's PR.
This PR adds extra handling of wholearchive libs with responsefiles.
(Simply said, I had to link several libs as wholearchive for Android, and ran into this bug).
The actual changes from this PR starts after b5a3826, the part before being the previous work to be merged with #456.
Cheers.
CC @rhoot for review as well, please.