Skip to content

Do not hardcode m64 v2#478

Open
belegdol wants to merge 2 commits intobkaradzic:masterfrom
belegdol:do-not-hardcode-m64-v2
Open

Do not hardcode m64 v2#478
belegdol wants to merge 2 commits intobkaradzic:masterfrom
belegdol:do-not-hardcode-m64-v2

Conversation

@belegdol
Copy link
Contributor

I switched from uname -p to uname -m, now the detection works on Darwin too.

@bkmgit
Copy link

bkmgit commented Jan 2, 2025

This error still exists on Aarch64 and i686 https://kojipkgs.fedoraproject.org//work/tasks/9426/127489426/build.log

@bkmgit bkmgit mentioned this pull request Jan 2, 2025
@hrw
Copy link

hrw commented Feb 5, 2026

and on risc-v 64bit as well.

Copy link
Owner

@bkaradzic bkaradzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems more like hack that targets only one specific build system. It might solve the issue you're having but can't be merged like this.

}

buildoptions {
"-m64",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with VS or other build systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants