Added FRAMEWORK_SEARCH_PATHS to Xcode 10+ projects #559
Open
DJLink wants to merge 1 commit intobkaradzic:masterfrom
Open
Added FRAMEWORK_SEARCH_PATHS to Xcode 10+ projects #559DJLink wants to merge 1 commit intobkaradzic:masterfrom
DJLink wants to merge 1 commit intobkaradzic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xcode has a field FRAMEWORK_SEARCH_PATHS, which is used to search header files inside frameworks. right now we have LIBRARY_SEARCH_PATHS, but FRAMEWORK_SEARCH_PATHS will allow searching within the .framework.
https://help.apple.com/xcode/mac/11.4/#/itcaec37c2a6
So I made it so FRAMEWORK_SEARCH_PATHS will have the same contents as LIBRARY_SEARCH_PATHS.
An example of this would be SDL2.framework header files, they have<SDL2/SDL_main.h> now, by pointing LIBRARY_SEARCH_PATHS to SDL2.framework/headers it wouldn't work. However, by pointing FRAMEWORK_SEARCH_PATHS to the root folder where SDL2.framework file is, it will work. This fixed my building projects at least.
I guess we could also have a separate field for FRAMEWORK_SEARCH_PATHS, but I feel like pulling the values there as well we don't have to change any existing scripts for anyone switching from a dylib to a .framework.
Let me know your thoughts. Thanks for considering.