Merged
Conversation
* flagItemIds had a race condition Fixes 20464 Assisted-by: Claude Opus 4.6 Diagnostics
on 'Delete notes': flowOfCardsUpdated was emitted and opExecuted was called, causing a double call to: * cardsAdapter.notifyDataSetChanged() * refreshBrowserUI() flowOfCardsUpdated was all that was necessary Assisted-by: Claude Opus 4.6 Initial diagnostic as an incorrect suggestion for a fix of 20556 Initial validation that the double call was no longer necessary I confirmed Some of the unit tests, all refactored Some automatic refactoring: extracting ensureOpWithHandler ensureOpWithHandler impl, with a little refactoring from me
A crash occurred if `cardIdToBeScrolledTo` was deleted in NOTES mode
* The ID was not validated
* The ID was not removed after a scroll
Optimization:
Don't call `viewModelScope.launch { searchJob?.join() }`
if there's nothing to be done
Fixes 20556
Introduced in b825f75
Assisted-by: Claude Opus 4.6
Diagnostics, some bad unit tests
90% of this is mine
* Fixed IDE warnings * Moved non-test methods outside the test class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )