Merged
Conversation
I forgot to enable this views when the state is available.
Checks for input: empty and not a number. More than 5 digits entered is also protected against with an input filter(to replicate desktop). Building/rebuilding of the deck will be disabled when any of these errors are encountered.
This button was being shown when the screen was loading and deck data was not available.
Follows desktop behavior: - when creating a new deck use the name generated at start - when editing a deck use its initial name Desktop uses TR.actionsOptionsFor(deckName), this is too big as a title so just the deck name is being shown.
Replaces the cards state AutoCompleteTextView(thanks Material theme) with a Spinner. Fixes a bug where the second filter state was not saved because the code considered it null when the deck being loaded didn't already had the second filter enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )