Skip to content

feat: replace OpenStruct with custom error class for JSON error response #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidewoode merged 1 commit into from
Jul 8, 2025
Merged

feat: replace OpenStruct with custom error class for JSON error response #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# frozen_string_literal: true

require "ostruct"

class ApplicationController < ActionController::Base
include Pagy::Backend
include SessionsHelper
Expand Down Expand Up @@ -36,7 +34,7 @@ class ApplicationController < ActionController::Base

rescue_from ActiveRecord::RecordNotFound do |error|
respond_to do |format|
format.json { render_json_error(OpenStruct.new(type: "RecordNotFound", message: error.message), :not_found) }
format.json { render_json_error(BlackCandy::CustomError.new("RecordNotFound", error.message), :not_found) }
format.html { render template: "errors/not_found", layout: "plain", status: :not_found }
end
end
Expand Down
2 changes: 2 additions & 0 deletions lib/black_candy/errors.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# frozen_string_literal: true

module BlackCandy
CustomError = Data.define(:type, :message)

class BaseError < StandardError
def type
self.class.name.split("::").last
Expand Down