Skip to content

Conversation

@nicm42
Copy link

@nicm42 nicm42 commented Apr 24, 2021

Description

Swapped the positions of the title and nav toggle, so the nag toggle is on the left of the tiel.

Motivation and Context

Fixes issue 165

How Has This Been Tested?

Tested in various browsers in Linux Mint and Windows 10.
Also re-ran relevant tests

Screenshots (if appropriate):

Before (Windows):
before windows

Before (Linux)
before linux

After (both):
after

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 24, 2021

Codecov Report

Merging #166 (8b62ada) into development (a7affeb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           development      #166   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files              285       285           
  Lines             3178      3188   +10     
  Branches           584       586    +2     
=============================================
+ Hits              3178      3188   +10     
Impacted Files Coverage Δ
...isplay/shared/header/components/HeaderLogoBlock.js 100.00% <ø> (ø)
.../display/views/help/components/AboutTrackerPane.js 100.00% <ø> (ø)
src/display/shared/columns/threads/LastPoster.js 100.00% <100.00%> (ø)
.../display/views/threads/components/CheckboxTable.js 100.00% <100.00%> (ø)
...rc/display/views/threads/components/_getTdProps.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7691747...8b62ada. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant