Fix target_id filtering for technologies and findings listing when using the API #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the API ?target_id parameter
Merged
TheTechromancer
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix that allows filtering using the target_id when listing findings and technologies (#56).
While working with the BBOT Server API I noticed that the
target_idparameter wouldn't work when listing findings or technologies (/v1/assets/findings/list?target_id=<target_id>,/v1/assets/technologies/list?target_id=<target_id>) whilst it would work for/v1/assets/list?target_id=<target_id>.It appeared to me that this occurred because the scope of the finding/technology wasn't inherited from the parent asset, which is now the case with this MR.
Feel free to ask for improvements, I tried to make this a 'quick fix' without breaking anything (some tests on my side seem to say that nothing broke) but original maintainer probably knows better than me 😄.