Skip to content

Conversation

@afbase
Copy link
Contributor

@afbase afbase commented May 17, 2025

Summary

this is the branch for just the docker package building.

Related Issues

related to #108 and #110

Changes

  • Feature implementation

Checklist

  • I have tested the changes (including writing unit tests).
  • I confirm that my implementation aligns with the canonical Typescript implementation and/or atproto spec
  • I have updated relevant documentation.
  • I have formatted my code correctly
  • I have provided examples for how this code works or will be used

@afbase afbase mentioned this pull request May 17, 2025
2 tasks
@afbase
Copy link
Contributor Author

afbase commented May 19, 2025

@rudyfraser

I'm still getting 403s to make an image on blacksky-algorithms organization. Tomorrow, I'm going to see if i can make images on my own account to unblock me for now.

Would you mind trying to re-run this job? I'm wondering if the github.actor matters?

@afbase afbase marked this pull request as ready for review May 21, 2025 07:28
@afbase afbase requested a review from rudyfraser May 21, 2025 07:28
@afbase afbase mentioned this pull request May 21, 2025
9 tasks
@afbase
Copy link
Contributor Author

afbase commented May 21, 2025

Workflow does the follow:

  1. determine which workspace members need to be built and tested.
  2. determine which dockerfiles need to be build, if any. docker will run a build only when a fork repository makes a PR. When blacksky-algorithms runs (e.g. upon merge), docker will run a build-and-push to create a package.

@rudyfraser rudyfraser merged commit 4420f12 into blacksky-algorithms:main May 22, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants