BugFix:Token Validation#42
Merged
rudyfraser merged 1 commit intoblacksky-algorithms:mainfrom Feb 3, 2025
Merged
Conversation
2. Updates possible token values to be those allowed in the bsky client
Contributor
Author
|
Saw it didn't like my format, will update |
Contributor
Author
|
Actually,I'm not sure what the problem is with it |
Member
|
Don't worry about the formatting. I'll hit everything with a |
rudyfraser
approved these changes
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current token validation behavior causes tokens to always be expired as the token is measured in seconds, but the comparison uses microseconds. This fixes that issue.
In addition, the bsky client doesn't allow for certain characters in the token value, so have removed those from possible values to allow for support.