PDS: Fix catcher error handling#51
Merged
rudyfraser merged 5 commits intoblacksky-algorithms:mainfrom Feb 14, 2025
Merged
Conversation
Contributor
Author
|
Merged latest main in |
TheRipperoni
changed the title
2. Ran rustfmt
rudyfraser
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior when request guards are triggered returns a http status of 500. This changes the behavior to respond as is intended by utilizing ApiError.
Technical note, the use of request.local_cache is to allow for us to pass the error response back to the catcher. Rocket has plans to add behavior to pass error bodies to the catcher in the future, but it is not currently supported otherwise.