PDS: Implemented Request PLC Signature API#55
Merged
rudyfraser merged 7 commits intoblacksky-algorithms:mainfrom Feb 15, 2025
Merged
PDS: Implemented Request PLC Signature API#55rudyfraser merged 7 commits intoblacksky-algorithms:mainfrom
rudyfraser merged 7 commits intoblacksky-algorithms:mainfrom
Conversation
2. Ran rustfmt
# Conflicts: # rsky-pds/src/main.rs
rudyfraser
reviewed
Feb 15, 2025
rsky-pds/src/apis/com/atproto/identity/request_plc_operation_signature.rs
Outdated
Show resolved
Hide resolved
rudyfraser
reviewed
Feb 15, 2025
rsky-pds/src/apis/com/atproto/identity/request_plc_operation_signature.rs
Outdated
Show resolved
Hide resolved
rudyfraser
requested changes
Feb 15, 2025
Member
rudyfraser
left a comment
There was a problem hiding this comment.
See comments related to returning error to client instead of panicking.
Member
|
Please also rerun cargo fmt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the API call for Request PLC Signature Operation API. Necessary step to have users migrate to a PDS