make cleantext work with list items with id #136
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
$cleantextis supposed to remove inline fields from the text of list and task items, but inline fields are not removed when the item has an id.Possible solutions
I see two possible approaches to solving this:
$cleantextremove the id as well as inline fields and indentation, and update the documentation accordingly.$cleantextremove just inline fields and indentation, as stated in the documentation, and return the id with the text.This PR
I chose to implement solution number 1 because I see ids as technical details, and not as part of the content of a task or list item.
As I've not contributed to this project before, please let me know if I should have approached this differently in any way.