fix(color): respect TTY detection for ANSI color output #972
+540
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ink-splatters
changed the title
ink-splatters
force-pushed
the
fix/color-tty-detection
branch
4 times, most recently
from
5baca27 to
b9fcd0b
Compare
Changes: - Add internal/colors package centralizing color handling - Only override auto-detection when --color or --no-color explicitly set, letting fatih/color's isatty detection do its job - Consolidate color constructors to avoid duplication across packages Signed-off-by: Peter A. <ink.splatters@pm.me>
ink-splatters
force-pushed
the
fix/color-tty-detection
branch
from
b9fcd0b to
02f2032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, color output was unconditionally controlled by the --no-color flag, overwriting fatih/color's automatic TTY detection. This caused ANSI escape codes to appear in redirected/piped output, violating UNIX conventions.
Changes:
Closes #971