fix: improve Docker socket detection and modernize app entry point#104
Open
Keralin wants to merge 1 commit intoblaise-io:masterfrom
Open
fix: improve Docker socket detection and modernize app entry point#104Keralin wants to merge 1 commit intoblaise-io:masterfrom
Keralin wants to merge 1 commit intoblaise-io:masterfrom
Conversation
- Detect Docker socket from docker context (fixes blaise-io#77, blaise-io#76, blaise-io#72, blaise-io#69) - Add fallback support for OrbStack and Colima sockets - Include /opt/homebrew/bin in PATH for Apple Silicon Macs - Modernize main.swift using NSApplication.shared.run() instead of deprecated NSApplicationMain() - Update AppDelegate access pattern in menu classes
Keralin
force-pushed
the
feature/modernize-and-fix-issues
branch
from
c6c657e to
fa104f9
Compare
Author
|
Hey @blaise-io any opinion about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker context inspectinstead of hardcoded paths/opt/homebrew/binin PATH for Homebrew on M1/M2 MacsNSApplicationMain()withNSApplication.shared.run()Issues Fixed
Changes
Process.swift:
dockerSocketproperty that checks docker context first, then falls back to known socket pathsgetDockerContextSocket()method usingdocker context inspect~/.orbstack/run/docker.sock) and Colima (~/.colima/default/docker.sock) paths/opt/homebrew/binto PATH for Apple Siliconmain.swift:
NSApplicationMain()with modernNSApplication.shared.run()Menu classes:
NSApplication.shared.delegate as? AppDelegateTest Plan