Skip to content

Tweaks#22656

Merged
hawkeye217 merged 12 commits intodevfrom
tweaks
Mar 26, 2026
Merged

Tweaks#22656
hawkeye217 merged 12 commits intodevfrom
tweaks

Conversation

@hawkeye217
Copy link
Copy Markdown
Collaborator

@hawkeye217 hawkeye217 commented Mar 26, 2026

Please read the contributing guidelines before submitting a PR.

Proposed change

This PR makes several changes in the Settings UI along with a few minor backend tweaks:

  • Disable both individual Save and Save All buttons while either operation is in progress
  • Show activity indicator and disable the Reset to Default/Global button while the API call is in progress
  • Refactor ArrayAsTextWidget to handle array-typed fields displayed as textareas like the additional_concerns field
  • Populate audio filter entries at the global config level for all audio labels
  • Add "Camera" and "Profile Overrides" header labels above the camera names and overridden sections in each profile's collapsible content
  • Fix enrichment panes (semantic search, genai, face recognition) to always show base config fields regardless of profile selection in the header dropdown
  • Return config validation errors in the json response so they show in frontend toasts
  • Enforce a minimum value of 2 for min_initialized. Some users have tried tweaking this thinking they would get better results with LPR, but it actually could make things worse (explanation here)
  • change preset-record-generic-audio-copy to transcode to aac to work around upstream ffmpeg 7.1 bug - more comments in code

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to discussion with maintainers (required for large/pinned features):

For new features

  • There is an existing feature request or discussion with community interest for this change.
    • Link:

AI disclosure

  • No AI tools were used in this PR.
  • AI tools were used in this PR. Details below:

AI tool(s) used (e.g., Claude, Copilot, ChatGPT, Cursor):

How AI was used (e.g., code generation, code review, debugging, documentation):

Extent of AI involvement (e.g., generated entire implementation, assisted with specific functions, suggested fixes):

Human oversight: Describe what manual review, testing, and validation you performed on the AI-generated portions.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I can explain every line of code in this PR if asked.
  • UI changes including text have used i18n keys and have been added to the en locale.
  • The code has been formatted using Ruff (ruff format frigate)

…ts profile leak

- Disable both Save and SaveAll buttons while either operation is in progress so users cannot trigger concurrent saves
- Show activity indicator on Reset to Default/Global button during the API call
- Enrichments panes (semantic search, genai, face recognition) now always show base config fields regardless of profile selection in the header dropdown
…dget

The additional_concerns field is list[str] in the backend but was using the textarea widget which produces a string value, causing validation errors.
Created a TextareaArrayWidget that converts between array (one item per line) and textarea display, and switched additional_concerns to use it
@hawkeye217 hawkeye217 merged commit 4772e6a into dev Mar 26, 2026
12 of 13 checks passed
@hawkeye217 hawkeye217 deleted the tweaks branch March 26, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants