Skip to content

Review labels widget#22664

Merged
NickM-27 merged 10 commits intodevfrom
review-labels
Mar 27, 2026
Merged

Review labels widget#22664
NickM-27 merged 10 commits intodevfrom
review-labels

Conversation

@hawkeye217
Copy link
Copy Markdown
Collaborator

Please read the contributing guidelines before submitting a PR.

Proposed change

This PR adds label selection switches to the Review settings UI for both Alerts and Detections sections.

  • ReviewLabelSwitchesWidget combines tracked object labels and audio listen labels, allowing users to configure review.alerts.labels and review.detections.labels directly from the UI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code
  • Documentation Update

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to discussion with maintainers (required for large/pinned features):

For new features

  • There is an existing feature request or discussion with community interest for this change.
    • Link:

AI disclosure

  • No AI tools were used in this PR.
  • AI tools were used in this PR. Details below:

AI tool(s) used (e.g., Claude, Copilot, ChatGPT, Cursor):

How AI was used (e.g., code generation, code review, debugging, documentation):

Extent of AI involvement (e.g., generated entire implementation, assisted with specific functions, suggested fixes):

Human oversight: Describe what manual review, testing, and validation you performed on the AI-generated portions.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I can explain every line of code in this PR if asked.
  • UI changes including text have used i18n keys and have been added to the en locale.
  • The code has been formatted using Ruff (ruff format frigate)

@NickM-27 NickM-27 merged commit c35cee2 into dev Mar 27, 2026
8 checks passed
@NickM-27 NickM-27 deleted the review-labels branch March 27, 2026 14:47
hawkeye217 added a commit that referenced this pull request Mar 29, 2026
use the new messages framework and revert the changes made in #22664
@hawkeye217 hawkeye217 mentioned this pull request Mar 29, 2026
15 tasks
NickM-27 pushed a commit that referenced this pull request Mar 29, 2026
* add config messages to sections and fields

* add alert variants

* add messages to types

* add detect fps, review, and audio messages

* add a basic set of messages

* remove emptySelectionHintKey from switches widget

use the new messages framework and revert the changes made in #22664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants