Skip to content

Make public classes that are used by lite gen code only package private #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make public classes that are used by lite gen code only package private #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83f5128
Move classes only used by lite gen code to package private.
blakeli0 Apr 18, 2025
333878c
Make LazyFieldLite public again because it is on the surface of Coded…
blakeli0 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion protobuf-api/src/main/java/com/google/protobuf/GeneratedMessageLite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
*
* @author [email protected] Kenton Varda
*/
public abstract class GeneratedMessageLite<
abstract class GeneratedMessageLite<
MessageType extends GeneratedMessageLite<MessageType, BuilderType>,
BuilderType extends GeneratedMessageLite.Builder<MessageType, BuilderType>>
extends AbstractMessageLite<MessageType, BuilderType> {
Expand Down
2 changes: 1 addition & 1 deletion protobuf-api/src/main/java/com/google/protobuf/MapEntryLite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*
* <p>Protobuf internal. Users shouldn't use.
*/
public class MapEntryLite<K, V> {
class MapEntryLite<K, V> {

static class Metadata<K, V> {
public final WireFormat.FieldType keyType;
Expand Down
2 changes: 1 addition & 1 deletion protobuf-api/src/main/java/com/google/protobuf/MapFieldLite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*
* <p>This class is a protobuf implementation detail. Users shouldn't use this class directly.
*/
public final class MapFieldLite<K, V> extends LinkedHashMap<K, V> {
final class MapFieldLite<K, V> extends LinkedHashMap<K, V> {

private boolean isMutable;

Expand Down
2 changes: 1 addition & 1 deletion protobuf-api/src/main/java/com/google/protobuf/UnknownFieldSetLite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*
* @author [email protected] (Daniel Weis)
*/
public final class UnknownFieldSetLite {
final class UnknownFieldSetLite {

// Arbitrarily chosen.
// TODO: Tune this number?
Expand Down