This PR includes all latest changes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der.LimitedInputStream to their own package private classes.
…od from FlattenedGeneratedMessageV3 instead.
…tract AbstractMessageLite.addAll method to Internal so that PluginProtos does not have to be dependent on AbstractMessageLite
…Move functionality required by the API package to TextFormatInternal or TextFormatEscaper
…ackage would not be able to access it.
This reverts commit be61c92.
This reverts commit bef8090.
This reverts commit 2e042b3.
This reverts commit 0ca49b5.
…ed by TextFormat.
…rnal for well-known types and PluginProtos. Move RepeatedFieldBuilderV3 and SingleFieldBuilderV3 to SDK package and restore the binary incompatibility, by change the constructor type from Message back to AbstractMessage.
Introduce RepeatedFieldBuilderV3Internal and SingleFieldBuilderV3Internal
…yLite because we are not going to move GeneratedMessageLite.
…age is generated or handwritten like DynamicMessage.
…actMessageInternal. Use these internal classes instead of flattened classes in gen code.
…derV3 from AbstractMessage to Message. This requires us extracting a few methods from AbstractMessage to Message as well.
…class up is a binary breaking change. Change the parameter type of newBuilderForType from AbstractMessage.BuilderParent Message.BuilderParent
…ernal.BuilderParent to Message.BuilderParent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.