Skip to content

Decouple ExtensionregistryLite from GeneratedMessageLite #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -765,7 +765,7 @@ static int decodeExtensionOrUnknownField(
throws IOException {
final int number = tag >>> 3;
GeneratedMessageLite.GeneratedExtension extension =
registers.extensionRegistry.findLiteExtensionByNumber(defaultInstance, number);
(GeneratedMessageLite.GeneratedExtension) registers.extensionRegistry.findLiteExtensionByNumber(defaultInstance, number);
if (extension == null) {
return decodeUnknownField(
tag, data, position, limit, getMutableUnknownFields(message), registers);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

package com.google.protobuf;

import java.util.Arrays;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
Expand Down Expand Up @@ -72,6 +73,19 @@ static Class<?> resolveExtensionClass() {
}
}
}
private static final Class<?> GENERATED_EXTENSION = getGeneratedExtensionClass();

private static Class<?> getGeneratedExtensionClass() {
try {
Class<?> generatedMessageLiteClass = Class.forName("com.google.protobuf.GeneratedMessageLite");
return Arrays.stream(generatedMessageLiteClass.getClasses())
.filter(innerClass -> innerClass.getName().equals("com.google.protobuf.GeneratedMessageLite$GeneratedExtension"))
.findFirst()
.get();
} catch (Throwable e) {
return null;
}
}

public static boolean isEagerlyParseMessageSets() {
return eagerlyParseMessageSets;
Expand Down Expand Up @@ -127,26 +141,28 @@ public ExtensionRegistryLite getUnmodifiable() {
*/
@SuppressWarnings("unchecked")
public <ContainingType extends MessageLite>
GeneratedMessageLite.GeneratedExtension<ContainingType, ?> findLiteExtensionByNumber(
ExtensionLite<ContainingType, ?> findLiteExtensionByNumber(
final ContainingType containingTypeDefaultInstance, final int fieldNumber) {
return (GeneratedMessageLite.GeneratedExtension<ContainingType, ?>)
return (ExtensionLite<ContainingType, ?>)
extensionsByNumber.get(new ObjectIntPair(containingTypeDefaultInstance, fieldNumber));
}

/** Add an extension from a lite generated file to the registry. */
public final void add(final GeneratedMessageLite.GeneratedExtension<?, ?> extension) {
extensionsByNumber.put(
new ObjectIntPair(extension.getContainingTypeDefaultInstance(), extension.getNumber()),
extension);
}
// public final void add(final ExtensionLite<?, ?> extension) {
// extensionsByNumber.put(
// new ObjectIntPair(extension, extension.getNumber()),
// extension);
// }

/**
* Add an extension from a lite generated file to the registry only if it is a non-lite extension
* i.e. {@link GeneratedMessageLite.GeneratedExtension}.
*/
public final void add(ExtensionLite<?, ?> extension) {
if (GeneratedMessageLite.GeneratedExtension.class.isAssignableFrom(extension.getClass())) {
add((GeneratedMessageLite.GeneratedExtension<?, ?>) extension);
if (GENERATED_EXTENSION.isAssignableFrom(extension.getClass())) {
extensionsByNumber.put(
new ObjectIntPair(extension, extension.getNumber()),
extension);
}
if (doFullRuntimeInheritanceCheck && ExtensionRegistryFactory.isFullRegistry(this)) {
try {
Expand All @@ -166,7 +182,7 @@ public final void add(ExtensionLite<?, ?> extension) {

ExtensionRegistryLite() {
this.extensionsByNumber =
new HashMap<ObjectIntPair, GeneratedMessageLite.GeneratedExtension<?, ?>>();
new HashMap<ObjectIntPair, ExtensionLite<?, ?>>();
}

static final ExtensionRegistryLite EMPTY_REGISTRY_LITE = new ExtensionRegistryLite(true);
Expand All @@ -179,7 +195,7 @@ public final void add(ExtensionLite<?, ?> extension) {
}
}

private final Map<ObjectIntPair, GeneratedMessageLite.GeneratedExtension<?, ?>>
private final Map<ObjectIntPair, ExtensionLite<?, ?>>
extensionsByNumber;

ExtensionRegistryLite(boolean empty) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ protected <MessageType extends MessageLite> boolean parseUnknownField(
// TODO: How much bytecode would be saved by not requiring the generated code to
// provide the default instance?
GeneratedExtension<MessageType, ?> extension =
extensionRegistry.findLiteExtensionByNumber(defaultInstance, fieldNumber);
(GeneratedExtension<MessageType, ?>) extensionRegistry.findLiteExtensionByNumber(defaultInstance, fieldNumber);

return parseExtension(input, extensionRegistry, extension, tag, fieldNumber);
}
Expand Down Expand Up @@ -808,7 +808,7 @@ private <MessageType extends MessageLite> void mergeMessageSetExtensionFromCoded
if (tag == WireFormat.MESSAGE_SET_TYPE_ID_TAG) {
typeId = input.readUInt32();
if (typeId != 0) {
extension = extensionRegistry.findLiteExtensionByNumber(defaultInstance, typeId);
extension = (GeneratedExtension<MessageType, ?>) extensionRegistry.findLiteExtensionByNumber(defaultInstance, typeId);
}

} else if (tag == WireFormat.MESSAGE_SET_MESSAGE_TAG) {
Expand Down