Allow setting local static key lazily in HandshakeState#62
Open
mmilata wants to merge 1 commit intoblckngm:masterfrom
Open
Allow setting local static key lazily in HandshakeState#62mmilata wants to merge 1 commit intoblckngm:masterfrom
mmilata wants to merge 1 commit intoblckngm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, nice library you've got there! I work for a company that would like to use it in its product with some changes, most of which don't belong upstream IMHO, except maybe this one?
It allows you to set the static key after HandshakeState is constructed - the idea is to set the key based on previous messages, e.g. based on remote's static key. Not sure whether to also add
assert!(self.s.is_none())to enforce setting it exactly once.