Merged
Conversation
…cape and SideDrawer components. Enhance Apps and Notes drawer visibility during resizing in Apps.spec.ts tests.
✅ Deploy Preview for bldrs-share-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Using GPT5.2 for this issue:
Fix
SideDrawerfrom behaving like a growing flex item (it was effectively allowed to grow/shrink in the row layout), which is what caused resizing Notes/Props to push the Apps drawer/app header off-screen instead of shrinking the center pane.RootLandscaperow layout so the center pane is the thing that shrinks when drawers resize, and the overall row doesn’t overflow horizontally.CadView’s viewer shrink calculation: it was readingsidebarWidthfrom the store (which doesn’t exist), so the viewer width style could become invalid. It now derives the sidebar width fromrightDrawerWidth/appsDrawerWidthwhen Notes/Apps are visible.Tests added/updated
src/Containers/RootLandscape.test.jsxto assert the center pane is flex-shrinkable and the root layout hides overflow.src/Components/Apps/Apps.spec.tswith a regression test that opens Notes + Apps, drags the Notes resize handle, and asserts the Apps drawer stays within the viewport and its header remains visible.Files changed
src/Components/SideDrawer/SideDrawer.jsxsrc/Containers/RootLandscape.jsxsrc/Containers/CadView.jsxsrc/Containers/RootLandscape.test.jsx(new)src/Components/Apps/Apps.spec.ts