Fix data race when batch.Reset. Fix #1460#1461
Open
lunny wants to merge 1 commit intoblevesearch:masterfrom
Open
Fix data race when batch.Reset. Fix #1460#1461lunny wants to merge 1 commit intoblevesearch:masterfrom
lunny wants to merge 1 commit intoblevesearch:masterfrom
Conversation
This was referenced Sep 8, 2020
Contributor
|
The comment in this fix suggests that the API is being used incorrectly. We do not support resetting a batch until after batch execution is complete, at which time copying that slice is not required. Can we start with a unit test that you think contains valid use of the API that fails the race dectector? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will try to fix the data race described on #1460.
When invoking
Batch, a goroutine will be ruined and will readbatch.IndexOps. Meanwhile, the user may callbatch.Resetimmediately which will clearbatch.IndexOps. The PR will copy the point of the map to the goroutine but not read it directly to avoid the datarace.