Unit tests for disjoint relation#1718
Open
metonymic-smokey wants to merge 4 commits intoblevesearch:masterfrom
Open
Unit tests for disjoint relation#1718metonymic-smokey wants to merge 4 commits intoblevesearch:masterfrom
metonymic-smokey wants to merge 4 commits intoblevesearch:masterfrom
Conversation
metonymic-smokey
force-pushed
the
disjoint
branch
from
833b064 to
a637556
Compare
Member
abhinavdangeti
left a comment
abhinavdangeti
left a comment
There was a problem hiding this comment.
@metonymic-smokey It appears there're some test failures here.
metonymic-smokey
commented
Aug 8, 2022
| github.com/bits-and-blooms/bitset v1.2.0 | ||
| github.com/blevesearch/bleve_index_api v1.0.3 | ||
| github.com/blevesearch/geo v0.1.13 | ||
| github.com/blevesearch/geo v0.1.14-0.20220806033936-256c7049d467 |
Contributor
Author
There was a problem hiding this comment.
@abhinavdangeti I am using v0.14 here so I reckon the failure isn't due to that.
Looking into it and will let you know, thanks!
Member
There was a problem hiding this comment.
Yes not related to the go.mod version. p.s. I created a v0.1.14 though.
Member
|
@metonymic-smokey I see a lot of test additions here. If you want to include this for v2.3.10 - this will need rebasing and make sure the checks pass. |
Contributor
Author
|
alright @abhinavdangeti, will let you know, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the newly added disjoint relation.