Move PartialMatch field to Explanation struct and update related logic#2103
Move PartialMatch field to Explanation struct and update related logic#2103CascadingRadium merged 1 commit intomasterfrom
Conversation
|
So just so we're clear here - partial_match will be set if an explicit disjunction were used and all its components did not match yes? |
|
|
Ok, then I disagree with your proposal here - we should be returning a partial_match when a disjunction's component doesn't match as well. |
|
like when the top-most query is a disjunction query ? |
Ya. |
abhinavdangeti
left a comment
There was a problem hiding this comment.
Per last conversation.
|
Actually, this approach has the limitation with disjunction + match queries where a single PartialMatch in the searchResult would lead to confusion regarding which component was partially matched (matchQuery1 / matchQuery2 / outerDisjuncts) i will propose a new solution where the partialMatch is reflected in the score explanation, where each subQuery's expl will have the partialMatch attribute |
764bc1a to
cbafdca
Compare
PartialMatchfield was returned for every hit, but this caused confusion in complex queries involving disjunctions and match queries. As a result, we movedPartialMatchto the score explanation, where each subquery's explanation will include its ownPartialMatch. This field is set only if the query uses the DisjunctionSearcher or scorer.