fix: linter warnings on test files#2159
Merged
abhinavdangeti merged 2 commits intoblevesearch:masterfrom Mar 10, 2025
Merged
Conversation
CascadingRadium
requested changes
Mar 7, 2025
Member
CascadingRadium
left a comment
CascadingRadium
left a comment
There was a problem hiding this comment.
as per above comments
Contributor
Author
|
thank you, @CascadingRadium, for your comment; I did the fix following your comments; let me know if you agree with the changes. |
CascadingRadium
approved these changes
Mar 7, 2025
abhinavdangeti
approved these changes
Mar 10, 2025
Member
|
Thank you for this contribution @christiangda . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I started using this project on my production workloads, I would like to contribute to the project.
This first contribution is focused on the easy part of cleaning the code according to the common
golang linters, likegolangci-lintandgopls. To impact the less possible in my contribution I started with_test.go files, I fixed some of the easy ones, there are too many and many of these linters warnings come from old go code.I hope this contribution starts helping and standardizing the code according to the golang version used.