fix: golangci-lint findings, third delivery#2167
Merged
CascadingRadium merged 7 commits intoblevesearch:masterfrom Mar 19, 2025
Merged
fix: golangci-lint findings, third delivery#2167CascadingRadium merged 7 commits intoblevesearch:masterfrom
CascadingRadium merged 7 commits intoblevesearch:masterfrom
Conversation
search/searcher/search_conjunction.go:53:2: S1001: should use copy(to, from) instead of a loop (gosimple) search/searcher/search_disjunction_slice.go:82:3: S1001: should use copy(to, from) instead of a loop (gosimple)
index/scorch/reader_test.go:72:2: ineffectual assignment to expectedCount (ineffassign)
search/sort.go:49:14: ineffectual assignment to ok (ineffassign) test: add test tables for function ParseSearchSortObj test: add unit test before the vadilation of the ok variable and test it after the change
index/upsidedown/row.go:645:7: ineffectual assignment to arrayPositionsLen (ineffassign)
analysis/token/keyword/keyword.go:38:11: SA6001: m[string(key)] would be more efficient than k := string(key); m[k] (staticcheck)
search/query/regexp.go:72:2: S1017: should replace this 'if' statement with an unconditional 'strings.TrimPrefix' (gosimple)
abhinavdangeti
requested review from
CascadingRadium,
Likith101,
Thejas-bhat and
abhinavdangeti
abhinavdangeti
approved these changes
Mar 18, 2025
CascadingRadium
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I started using this project on my production workloads, I would like to contribute to the project.
This third delivery is still fixing easy stuff like:
golangci-lint run ./... | grep "S1001:"golangci-lint run ./... | grep "ineffectual assignment"->golangci-lint run ./... | grep "S1017:"ifstatement with an unconditionalstrings.TrimPrefix(gosimple)search/sort_test.goto test a change before and after it