Validate scorch routine options when creating or opening a Bleve Index.#2170
Merged
CascadingRadium merged 2 commits intomasterfrom Mar 26, 2025
Merged
Validate scorch routine options when creating or opening a Bleve Index.#2170CascadingRadium merged 2 commits intomasterfrom
CascadingRadium merged 2 commits intomasterfrom
Conversation
Member
CascadingRadium
commented
Mar 24, 2025
CascadingRadium
commented
- If a malformed setting is used in the persistor/merger options, an async error is thrown leading to a crash loop in a live system.
- This PR adds a validation step to ensure that the options are valid before creating/opening the index.
- If a malformed setting is used in the persistor/merger options, an async error is thrown leading to a crash loop in a live system. - This PR adds a validation step to ensure that the options are valid before creating/opening the index.
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti and
metonymic-smokey
abhinavdangeti
requested changes
Mar 24, 2025
Member
abhinavdangeti
left a comment
abhinavdangeti
left a comment
There was a problem hiding this comment.
@CascadingRadium Good commit - it seems rather easy to add a unit test for this though, so let's add one along to exercise the code addition shall we.
Thejas-bhat
approved these changes
Mar 26, 2025
Likith101
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.