MB-70410: Simplify CoalesceQueue in hierarchical nested search#2283
Merged
CascadingRadium merged 1 commit intomasterfrom Feb 3, 2026
Merged
MB-70410: Simplify CoalesceQueue in hierarchical nested search#2283CascadingRadium merged 1 commit intomasterfrom
CoalesceQueue in hierarchical nested search#2283CascadingRadium merged 1 commit intomasterfrom
Conversation
CascadingRadium
changed the title
CoalesceQueue to defer coalescing until dequeue
CascadingRadium
changed the title
CoalesceQueue to defer coalescing until dequeueCoalesceQueue to defer coalescing until dequeue
CascadingRadium
changed the title
CoalesceQueue to defer coalescing until dequeueCoalesceQueue in hierarchical nested search
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the CoalesceQueue implementation used in nested conjunction search by deferring the coalescing of duplicate documents from enqueue time to dequeue time. This simplification removes the need for a separate map while maintaining identical behavior.
Changes:
- Removed the
itemsmap fromCoalesceQueuestructure, reducing memory overhead - Simplified
Enqueuemethod to append items without coalescing or error handling - Enhanced
Dequeuemethod to merge consecutive duplicates after sorting, handling recycling of merged items - Updated call sites in
Next()andAdvance()methods to match the new signature
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox and
maneuvertomars
abhinavdangeti
approved these changes
Feb 2, 2026
Likith101
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoalesceQueueused in nested conjunction search by moving coalescing from enqueue to dequeue. This removes the separate map and reduces memory use while keeping behavior the same.