MB-70410: [BP] Simplify CoalesceQueue in hierarchical nested search#2284
Merged
CascadingRadium merged 1 commit into8.0.x-couchbasefrom Feb 3, 2026
Merged
MB-70410: [BP] Simplify CoalesceQueue in hierarchical nested search#2284CascadingRadium merged 1 commit into8.0.x-couchbasefrom
CoalesceQueue in hierarchical nested search#2284CascadingRadium merged 1 commit into8.0.x-couchbasefrom
Conversation
CascadingRadium
requested review from
Likith101,
Thejas-bhat,
abhinavdangeti,
capemox,
Copilot and
maneuvertomars
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CoalesceQueue implementation used in nested conjunction search by refactoring when duplicate document matches are coalesced. Instead of maintaining a separate map and coalescing at enqueue time, the new implementation defers coalescing to dequeue time after sorting, reducing memory usage while preserving the same behavior.
Changes:
- Removed the
itemsmap fromCoalesceQueuestructure to reduce memory overhead - Simplified
Enqueueto just append items without checking for duplicates - Updated
Dequeueto merge consecutive duplicates after sorting - Removed error handling from
EnqueueandDequeuemethods as it's no longer needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhinavdangeti
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoalesceQueueused in nested conjunction search by moving coalescing from enqueue to dequeue. This removes the separate map and reduces memory use while keeping behavior the same.