Skip to content

MB-65473: Adapt to change in bleve_index_api interface for VectorReader#28

Merged
abhinavdangeti merged 4 commits intomasterfrom
prefilterOpt
Apr 2, 2025
Merged

MB-65473: Adapt to change in bleve_index_api interface for VectorReader#28
abhinavdangeti merged 4 commits intomasterfrom
prefilterOpt

Conversation

@abhinavdangeti
Copy link
Member Author

@CascadingRadium can you confirm that segIdx in SegmentEligibleDocs(..) in the single document index is zero?

@coveralls
Copy link

coveralls commented Mar 24, 2025

Pull Request Test Coverage Report for Build 14201074977

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.464%

Totals Coverage Status
Change from base Build 13844035984: 0.0%
Covered Lines: 488
Relevant Lines: 571

💛 - Coveralls

@CascadingRadium
Copy link
Member

provided that a sear user is configuring the VectorReader usage appropriately (sear does not have the concept of bleve/zap) then this logic is correct. In the bleve side of things, if there is only 1 document, there will be only 1 segment to search, and selector.SegmentEligibleDocs(0) can either have 1 value (if eligible) or be nil/empty which is handled here using the NewVectorFieldReaderEmpty

@abhinavdangeti abhinavdangeti merged commit 07e3bbf into master Apr 2, 2025
10 checks passed
@abhinavdangeti abhinavdangeti deleted the prefilterOpt branch April 2, 2025 15:39
@abhinavdangeti
Copy link
Member Author

v0.3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants