Skip to content

fix: use fmt.Appendf to add to byte buffer #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
Merged

fix: use fmt.Appendf to add to byte buffer #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions internal/state/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ func (s *State) UpdateDomain(
)
}
// Delete old records in tracking key that are no longer present after this update
domainRecordsKey := []byte(fmt.Sprintf("d_%s_records", domainName))
domainRecordsKey := fmt.Appendf(nil, "d_%s_records", domainName)
domainRecordsItem, err := txn.Get(domainRecordsKey)
if err != nil {
if !errors.Is(err, badger.ErrKeyNotFound) {
Expand Down Expand Up @@ -289,13 +289,13 @@ func (s *State) LookupRecords(
recordName = strings.Trim(recordName, `.`)
err := s.db.View(func(txn *badger.Txn) error {
for _, recordType := range recordTypes {
keyPrefix := []byte(
fmt.Sprintf(
"r_%s_%s_",
strings.ToUpper(recordType),
recordName,
),
keyPrefix := fmt.Appendf(
nil,
"r_%s_%s_",
strings.ToUpper(recordType),
recordName,
)

it := txn.NewIterator(badger.DefaultIteratorOptions)
defer it.Close()
for it.Seek(keyPrefix); it.ValidForPrefix(keyPrefix); it.Next() {
Expand Down
Loading