Skip to content

fix: range over int vs loop+increment #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

fix: range over int vs loop+increment #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/handshake/block.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (b *Block) Decode(r *bytes.Buffer) error {
if err != nil {
return err
}
for i := uint64(0); i < txCount; i++ {
for range txCount {
var tmpTx Transaction
if err := tmpTx.Decode(r); err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion internal/handshake/covenant.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func (c *GenericCovenant) Decode(r io.Reader) error {
if err != nil {
return err
}
for i := uint64(0); i < itemCount; i++ {
for range itemCount {
itemLength, err := binary.ReadUvarint(r.(io.ByteReader))
if err != nil {
return err
Expand Down
8 changes: 4 additions & 4 deletions internal/handshake/transaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ func (t *Transaction) Decode(r *bytes.Buffer) error {
if err != nil {
return err
}
for i := uint64(0); i < inCount; i++ {
for range inCount {
var tmpInput TransactionInput
if err := tmpInput.Decode(r); err != nil {
return err
Expand All @@ -65,7 +65,7 @@ func (t *Transaction) Decode(r *bytes.Buffer) error {
if err != nil {
return err
}
for i := uint64(0); i < outCount; i++ {
for range outCount {
var tmpOutput TransactionOutput
if err := tmpOutput.Decode(r); err != nil {
return err
Expand All @@ -87,7 +87,7 @@ func (t *Transaction) Decode(r *bytes.Buffer) error {
origData = make([]byte, r.Len())
copy(origData, r.Bytes())
// Witnesses
for i := uint64(0); i < inCount; i++ {
for i := range inCount {
if err := t.Inputs[i].DecodeWitness(r); err != nil {
return err
}
Expand Down Expand Up @@ -141,7 +141,7 @@ func (i *TransactionInput) DecodeWitness(r io.Reader) error {
return err
}
i.Witness = make([][]byte, witnessCount)
for j := uint64(0); j < witnessCount; j++ {
for j := range witnessCount {
itemLength, err := binary.ReadUvarint(r.(io.ByteReader))
if err != nil {
return err
Expand Down