Skip to content

fix: use slices.Sort method instead of sort.Slice #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2025
Merged

fix: use slices.Sort method instead of sort.Slice #1014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions protocol/handshake/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ package handshake
import (
"errors"
"fmt"
"sort"
"slices"

"github.com/blinklabs-io/gouroboros/protocol"
)
Expand Down Expand Up @@ -105,9 +105,7 @@ func (s *Server) handleProposeVersions(msg protocol.Message) error {
}

// sort asending - iterating over map is not deterministic
sort.Slice(supportedVersions, func(i, j int) bool {
return supportedVersions[i] < supportedVersions[j]
})
slices.Sort(supportedVersions)

msgRefuse := NewMsgRefuse(
[]any{
Expand Down
10 changes: 3 additions & 7 deletions protocol/versions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

package protocol

import "sort"
import "slices"

// The NtC protocol versions have the 15th bit set in the handshake
const ProtocolVersionNtCOffset = 0x8000
Expand Down Expand Up @@ -322,9 +322,7 @@ func GetProtocolVersionsNtC() []uint16 {
}

// sort asending - iterating over map is not deterministic
sort.Slice(versions, func(i, j int) bool {
return versions[i] < versions[j]
})
slices.Sort(versions)

return versions
}
Expand All @@ -339,9 +337,7 @@ func GetProtocolVersionsNtN() []uint16 {
}

// sort asending - iterating over map is not deterministic
sort.Slice(versions, func(i, j int) bool {
return versions[i] < versions[j]
})
slices.Sort(versions)

return versions
}
Expand Down
Loading