Skip to content

fix(muxer): Return better error message when the peer closes the connection #1038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2025
Merged

fix(muxer): Return better error message when the peer closes the connection #1038

merged 2 commits into from
Jun 14, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Replaced plain io.EOF with descriptive wrapped errors like peer closed the connection while reading header: EOF
    in Muxer.readLoop().
  2. Updated downstream handling in setupConnection() function and muxer error forwarding to preserve
    the wrapped errors.

Closes #518

@arepala-uml arepala-uml requested review from wolf31o2 and agaffney June 12, 2025 06:28
agaffney
agaffney requested changes Jun 12, 2025
View reviewed changes
@arepala-uml arepala-uml requested a review from agaffney June 14, 2025 05:45
@wolf31o2 wolf31o2 marked this pull request as ready for review June 14, 2025 13:37
@wolf31o2 wolf31o2 requested a review from a team as a code owner June 14, 2025 13:37
@wolf31o2 wolf31o2 merged commit 40e720d into main Jun 14, 2025
9 checks passed
@wolf31o2 wolf31o2 deleted the peer_connection branch June 14, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaffney agaffney agaffney approved these changes

@wolf31o2 wolf31o2 Awaiting requested review from wolf31o2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return better error message when the peer closes the connection
3 participants
@arepala-uml @agaffney @wolf31o2