Skip to content

fix: prefer range over int vs for loop #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025
Merged

fix: prefer range over int vs for loop #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ledger/alonzo/pparams_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,12 +132,12 @@ func TestAlonzoProtocolParamsUpdate(t *testing.T) {
func TestAlonzoProtocolParametersUpdateFromGenesis(t *testing.T) {
// Create cost models with numeric string keys
plutusV1CostModel := make(map[string]int)
for i := 0; i < 166; i++ {
for i := range 166 {
plutusV1CostModel[strconv.Itoa(i)] = i + 1 // "0":1, "1":2, etc.
}

plutusV2CostModel := make(map[string]int)
for i := 0; i < 175; i++ {
for i := range 175 {
plutusV2CostModel[strconv.Itoa(i)] = i + 1 // "0":1, "1":2, etc.
}

Expand Down Expand Up @@ -185,7 +185,7 @@ func TestAlonzoProtocolParametersUpdateFromGenesis(t *testing.T) {
func TestCostModelArrayFormat(t *testing.T) {
// Create cost model with numeric string keys
plutusV1CostModel := make(map[string]int)
for i := 0; i < 166; i++ {
for i := range 166 {
plutusV1CostModel[strconv.Itoa(i)] = i + 1 // "0":1, "1":2, etc.
}

Expand Down Expand Up @@ -261,7 +261,7 @@ func TestScientificNotationInCostModels(t *testing.T) {
}

expected := []int64{2477736, 1500000, 1000000}
for i := 0; i < 3; i++ {
for i := range 3 {
if params.CostModels[alonzo.PlutusV1Key][i] != expected[i] {
t.Errorf("parameter %d conversion failed: got %d, want %d",
i, params.CostModels[alonzo.PlutusV1Key][i], expected[i])
Expand Down
Loading