Skip to content

feat: TxSubmission MsgDone callback support #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

feat: TxSubmission MsgDone callback support #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions protocol/txsubmission/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ func (s *Server) handleDone() error {
"role", "server",
"connection_id", s.callbackContext.ConnectionId.String(),
)
// Call the user callback function
if s.config != nil && s.config.DoneFunc != nil {
if err := s.config.DoneFunc(s.callbackContext); err != nil {
return err
}
}
// Restart protocol
s.Stop()
s.initProtocol()
Expand Down
9 changes: 9 additions & 0 deletions protocol/txsubmission/txsubmission.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ type Config struct {
RequestTxIdsFunc RequestTxIdsFunc
RequestTxsFunc RequestTxsFunc
InitFunc InitFunc
DoneFunc DoneFunc
IdleTimeout time.Duration
}

Expand All @@ -137,6 +138,7 @@ type (
RequestTxIdsFunc func(CallbackContext, bool, uint16, uint16) ([]TxIdAndSize, error)
RequestTxsFunc func(CallbackContext, []TxId) ([]TxBody, error)
InitFunc func(CallbackContext) error
DoneFunc func(CallbackContext) error
)

// New returns a new TxSubmission object
Expand Down Expand Up @@ -186,6 +188,13 @@ func WithInitFunc(initFunc InitFunc) TxSubmissionOptionFunc {
}
}

// WithDoneFunc specifies the Done callback function
func WithDoneFunc(doneFunc DoneFunc) TxSubmissionOptionFunc {
return func(c *Config) {
c.DoneFunc = doneFunc
}
}

// WithIdleTimeout specifies the timeout for waiting for new transactions from the remote node's mempool
func WithIdleTimeout(timeout time.Duration) TxSubmissionOptionFunc {
return func(c *Config) {
Expand Down
Loading