Skip to content

feat(ledger): Add ToPlutusData() function to gov vote-related types #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

feat(ledger): Add ToPlutusData() function to gov vote-related types #1117

merged 2 commits into from
Jul 28, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Implemented Voter.ToPlutusData(), Vote.ToPlutusData(), and VotingProcedure.ToPlutusData() methods.
  2. Converts voter types (Constitutional Committee/DRep/Staking Pool) to PlutusData by wrapping hashes in StakeCredential structures with different constructor numbers (0/1/2).
  3. Created gov_test.go with test coverage for all three types, testing all voter types, vote types.

Closes #1105

@arepala-uml
feat(ledger):Implemented ToPlutusData function for Voter, Vote, and V…
4dbfa9a 
…otingProcedure types and written test functions as well

Signed-off-by: Akhil Repala <[email protected]>
@arepala-uml arepala-uml marked this pull request as ready for review July 28, 2025 00:26
@arepala-uml arepala-uml requested a review from a team as a code owner July 28, 2025 00:26
@arepala-uml arepala-uml requested review from wolf31o2 and agaffney July 28, 2025 00:26
agaffney
agaffney requested changes Jul 28, 2025
View reviewed changes
ledger/common/gov.go Outdated
case Vote(GovVoteAbstain):
return data.NewConstr(2)
default:
return data.NewConstr(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should return nil if we don't know the proper representation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes and please review it.

ledger/common/gov.go Outdated
case VoterTypeStakingPoolKeyHash:
return data.NewConstr(2, data.NewByteString(v.Hash[:]))
default:
return data.NewConstr(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return nil

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes and please review it.

@arepala-uml arepala-uml requested a review from agaffney July 28, 2025 02:51
@agaffney agaffney merged commit 1c7eca1 into main Jul 28, 2025
8 checks passed
@agaffney agaffney deleted the plutus_vote branch July 28, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agaffney agaffney agaffney approved these changes

@wolf31o2 wolf31o2 Awaiting requested review from wolf31o2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ToPlutusData() function to gov vote-related types
2 participants
@arepala-uml @agaffney