Skip to content

fix(ledger/byron): ByronGenesis.FtsSeed can be object #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2025
Merged

fix(ledger/byron): ByronGenesis.FtsSeed can be object #1190

merged 3 commits into from
Sep 18, 2025

Conversation

arepala-uml
Copy link
Contributor

  1. Added custom type ByronGenesisFtsSeed with UnmarshalJSON/MarshalJSON.
  2. Allow ftsSeed to be parsed from either a JSON string or an empty object.
  3. Update tests to expect ByronFtsSeed instead of plain string and added optional test coverage for empty object case.

Closes #1039

@arepala-uml arepala-uml marked this pull request as ready for review September 15, 2025 05:52
@arepala-uml arepala-uml requested a review from a team as a code owner September 15, 2025 05:52
agaffney
agaffney previously requested changes Sep 15, 2025
View reviewed changes
@arepala-uml
fix(ledger/byron): removed the first byte checking part from ftsSeed …
32c9688 
…UnmarshalJSON and attempted string, empty object & null

Signed-off-by: Akhil Repala <[email protected]>
@wolf31o2 wolf31o2 dismissed agaffney’s stale review September 18, 2025 11:47

Requested changes made

@wolf31o2 wolf31o2 merged commit a57c097 into main Sep 18, 2025
9 checks passed
@wolf31o2 wolf31o2 deleted the byrongenesis_ftsseed branch September 18, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ByronGenesis.FtsSeed can be object
3 participants
@arepala-uml @wolf31o2 @agaffney