Skip to content

fix: use Id instead of Hash for transactions #1202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

fix: use Id instead of Hash for transactions #1202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/tx-submission/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func main() {
// Wait until we're done
<-doneChan

fmt.Printf("Successfully sent transaction %x\n", tx.Hash())
fmt.Printf("Successfully sent transaction %x\n", tx.Id())

if err := o.Close(); err != nil {
fmt.Printf("ERROR: failed to close connection: %s\n", err)
Expand Down
2 changes: 1 addition & 1 deletion ledger/common/script/context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func NewTxInfoV3FromTransaction(
Signatories: signatoriesInfo(tx.RequiredSigners()),
Redeemers: redeemers,
Data: tmpData,
Id: tx.Hash(),
Id: tx.Id(),
Votes: votes,
ProposalProcedures: proposalProcedures,
}
Expand Down
2 changes: 1 addition & 1 deletion ledger/conway/conway_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func TestConwayTx_Utxorpc(t *testing.T) {
t.Fatalf("failed to convert Conway tx to utxorpc: %v", err)
}

expHash := tx.Hash().Bytes()
expHash := tx.Id().Bytes()
if !bytes.Equal(utxoTx.Hash, expHash) {
t.Errorf("tx hash mismatch\nexpected: %x\nactual : %x", expHash, utxoTx.Hash)
}
Expand Down