Skip to content

fix: use TxIds for ack count in TxSubmission #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: use TxIds for ack count in TxSubmission #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions protocol/txsubmission/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,13 @@ func (s *Server) RequestTxIds(
if err := s.SendMessage(msg); err != nil {
return nil, err
}
// Reset ack count
s.ackCount = 0
// Wait for result
txIds, ok := <-s.requestTxIdsResultChan
if !ok {
return nil, protocol.ProtocolShuttingDownError
}
// Update ack count for next call
s.ackCount = len(txIds)
return txIds, nil
}

Expand All @@ -129,8 +129,6 @@ func (s *Server) RequestTxs(txIds []TxId) ([]TxBody, error) {
if !ok {
return nil, protocol.ProtocolShuttingDownError
}
// Set the ack count for the next RequestTxIds request based on the number we got for this one
s.ackCount = len(txs)
return txs, nil
}

Expand Down