feat(address): improved NewAddress to support both bech32/base58 #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agaffney
reviewed
Oct 15, 2024
ledger/common/address.go
Outdated
| var decoded []byte | ||
| var err error | ||
|
|
||
| if isMixedCase(addr) { |
There was a problem hiding this comment.
We can probably drop the helper function and just do something like if strings.ToLower(addr) != addr {. This will effectively detect upper-case characters in the string, which we should never see for bech32.
There was a problem hiding this comment.
That's a smart move, thanks
Signed-off-by: Ales Verbic <[email protected]>
verbotenj
force-pushed
the
feat/imporove-newaddress
branch
from
1f89beb to
eca38ba
Compare
agaffney
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.