Skip to content

fix: connection.BlockFetch().Client.GetBlock potential deadlock #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: connection.BlockFetch().Client.GetBlock potential deadlock #787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions protocol/blockfetch/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ func (c *Client) GetBlock(point common.Point) (ledger.Block, error) {
}
err, ok := <-c.startBatchResultChan
if !ok {
c.busyMutex.Unlock()
return nil, protocol.ProtocolShuttingDownError
}
if err != nil {
Expand All @@ -172,6 +173,7 @@ func (c *Client) GetBlock(point common.Point) (ledger.Block, error) {
}
block, ok := <-c.blockChan
if !ok {
c.busyMutex.Unlock()
return nil, protocol.ProtocolShuttingDownError
}
return block, nil
Expand Down