Skip to content

fix(protocol): include all protocol states in switch #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix(protocol): include all protocol states in switch #932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions protocol/protocol.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,8 +427,12 @@ func (p *Protocol) stateLoop(ch <-chan protocolStateTransition) {

// Mark protocol as ready to send/receive based on role and agency of the new state
switch p.config.StateMap[currentState].Agency {
case AgencyNone:
return
case AgencyClient:
switch p.config.Role {
case ProtocolRoleNone:
return
case ProtocolRoleClient:
select {
case p.sendReadyChan <- true:
Expand All @@ -442,6 +446,8 @@ func (p *Protocol) stateLoop(ch <-chan protocolStateTransition) {
}
case AgencyServer:
switch p.config.Role {
case ProtocolRoleNone:
return
case ProtocolRoleServer:
select {
case p.sendReadyChan <- true:
Expand Down