chore(golangci-lint): enable format, import, and unused presets; disable depguard

.golangci.yml

@@ -4,6 +4,11 @@ issues:
   max-issues-per-linter: 0
   max-same-issues: 0
 linters:
+  disable:
+    - asasalint
+    - depguard
+    - recvcheck
+    - unparam
   enable:
     - errcheck
     - gosimple
@@ -12,12 +17,15 @@ linters:
     - staticcheck
     - unused
     # Defaults above ours below
-  disable:
-    - asasalint
-    - recvcheck
+    - copyloopvar
+    - usestdlibvars
+    - whitespace
   presets:
     - bugs
+    - format
+    - import
     - performance
+    - unused
 #linters-settings:
 #  errcheck:
 #    check-type-assertions: true

cbor/cbor.go

@@ -36,8 +36,10 @@ const (
 type RawMessage = _cbor.RawMessage
 
 // Alias for Tag for convenience
-type Tag = _cbor.Tag
-type RawTag = _cbor.RawTag
+type (
+	Tag    = _cbor.Tag
+	RawTag = _cbor.RawTag
+)
 
 // Useful for embedding and easier to remember
 type StructAsArray struct {

cbor/decode.go

@@ -115,8 +115,10 @@ func DecodeById(
 	return ret, nil
 }
 
-var decodeGenericTypeCache = map[reflect.Type]reflect.Type{}
-var decodeGenericTypeCacheMutex sync.RWMutex
+var (
+	decodeGenericTypeCache      = map[reflect.Type]reflect.Type{}
+	decodeGenericTypeCacheMutex sync.RWMutex
+)
 
 // DecodeGeneric decodes the specified CBOR into the destination object without using the
 // destination object's UnmarshalCBOR() function

cbor/encode.go

@@ -39,8 +39,10 @@ func Encode(data interface{}) ([]byte, error) {
 	return buf.Bytes(), err
 }
 
-var encodeGenericTypeCache = map[reflect.Type]reflect.Type{}
-var encodeGenericTypeCacheMutex sync.RWMutex
+var (
+	encodeGenericTypeCache      = map[reflect.Type]reflect.Type{}
+	encodeGenericTypeCacheMutex sync.RWMutex
+)
 
 // EncodeGeneric encodes the specified object to CBOR without using the source object's
 // MarshalCBOR() function

cbor/value.go

@@ -248,7 +248,6 @@ func generateAstJsonMap[T map[any]any | Map](v T) ([]byte, error) {
 		strings.Join(tmpItems, ","),
 	)
 	return []byte(tmpJson), nil
-
 }
 
 type Constructor struct {

cmd/gouroboros/mem_usage.go

@@ -19,14 +19,13 @@ import (
 	"fmt"
 	"log"
 	"net/http"
+	// #nosec G108
+	_ "net/http/pprof"
 	"os"
 	"runtime"
 	"runtime/pprof"
 	"time"
 
-	// #nosec G108
-	_ "net/http/pprof"
-
 	ouroboros "github.com/blinklabs-io/gouroboros"
 )
 

cmd/gouroboros/server.go

@@ -26,14 +26,14 @@ import (
 
 type serverFlags struct {
 	flagset *flag.FlagSet
-	//txFile  string
+	// txFile  string
 }
 
 func newServerFlags() *serverFlags {
 	f := &serverFlags{
 		flagset: flag.NewFlagSet("server", flag.ExitOnError),
 	}
-	//f.flagset.StringVar(&f.txFile, "tx-file", "", "path to the transaction file to submit")
+	// f.flagset.StringVar(&f.txFile, "tx-file", "", "path to the transaction file to submit")
 	return f
 }
 

cmd/tx-submission/main.go

@@ -33,10 +33,12 @@ type txSubmissionFlags struct {
 	rawTxFile string
 }
 
-var txBytes []byte
-var txHash [32]byte
-var sentTx bool
-var doneChan chan any
+var (
+	txBytes  []byte
+	txHash   [32]byte
+	sentTx   bool
+	doneChan chan any
+)
 
 func main() {
 	// Parse commandline

ledger/allegra.go

@@ -20,11 +20,13 @@ import "github.com/blinklabs-io/gouroboros/ledger/allegra"
 // to keep existing code working after a refactor of the ledger package
 
 // Allegra types
-type AllegraBlock = allegra.AllegraBlock
-type AllegraTransaction = allegra.AllegraTransaction
-type AllegraTransactionBody = allegra.AllegraTransactionBody
-type AllegraProtocolParameters = allegra.AllegraProtocolParameters
-type AllegraProtocolParameterUpdate = allegra.AllegraProtocolParameterUpdate
+type (
+	AllegraBlock                   = allegra.AllegraBlock
+	AllegraTransaction             = allegra.AllegraTransaction
+	AllegraTransactionBody         = allegra.AllegraTransactionBody
+	AllegraProtocolParameters      = allegra.AllegraProtocolParameters
+	AllegraProtocolParameterUpdate = allegra.AllegraProtocolParameterUpdate
+)
 
 // Allegra constants
 const (

ledger/allegra/allegra.go

@@ -21,7 +21,6 @@ import (
 	"github.com/blinklabs-io/gouroboros/cbor"
 	"github.com/blinklabs-io/gouroboros/ledger/common"
 	"github.com/blinklabs-io/gouroboros/ledger/shelley"
-
 	utxorpc "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
 )
 
@@ -36,12 +35,10 @@ const (
 	TxTypeAllegra = 2
 )
 
-var (
-	EraAllegra = common.Era{
-		Id:   EraIdAllegra,
-		Name: EraNameAllegra,
-	}
-)
+var EraAllegra = common.Era{
+	Id:   EraIdAllegra,
+	Name: EraNameAllegra,
+}
 
 func init() {
 	common.RegisterEra(EraAllegra)

ledger/alonzo.go

@@ -20,14 +20,16 @@ import "github.com/blinklabs-io/gouroboros/ledger/alonzo"
 // to keep existing code working after a refactor of the ledger package
 
 // Alonzo types
-type AlonzoBlock = alonzo.AlonzoBlock
-type AlonzoBlockHeader = alonzo.AlonzoBlockHeader
-type AlonzoTransaction = alonzo.AlonzoTransaction
-type AlonzoTransactionBody = alonzo.AlonzoTransactionBody
-type AlonzoTransactionOutput = alonzo.AlonzoTransactionOutput
-type AlonzoTransactionWitnessSet = alonzo.AlonzoTransactionWitnessSet
-type AlonzoProtocolParameters = alonzo.AlonzoProtocolParameters
-type AlonzoProtocolParameterUpdate = alonzo.AlonzoProtocolParameterUpdate
+type (
+	AlonzoBlock                   = alonzo.AlonzoBlock
+	AlonzoBlockHeader             = alonzo.AlonzoBlockHeader
+	AlonzoTransaction             = alonzo.AlonzoTransaction
+	AlonzoTransactionBody         = alonzo.AlonzoTransactionBody
+	AlonzoTransactionOutput       = alonzo.AlonzoTransactionOutput
+	AlonzoTransactionWitnessSet   = alonzo.AlonzoTransactionWitnessSet
+	AlonzoProtocolParameters      = alonzo.AlonzoProtocolParameters
+	AlonzoProtocolParameterUpdate = alonzo.AlonzoProtocolParameterUpdate
+)
 
 // Alonzo constants
 const (

ledger/alonzo/alonzo.go

@@ -23,7 +23,6 @@ import (
 	"github.com/blinklabs-io/gouroboros/ledger/common"
 	"github.com/blinklabs-io/gouroboros/ledger/mary"
 	"github.com/blinklabs-io/gouroboros/ledger/shelley"
-
 	utxorpc "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
 )
 
@@ -38,12 +37,10 @@ const (
 	TxTypeAlonzo = 4
 )
 
-var (
-	EraAlonzo = common.Era{
-		Id:   EraIdAlonzo,
-		Name: EraNameAlonzo,
-	}
-)
+var EraAlonzo = common.Era{
+	Id:   EraIdAlonzo,
+	Name: EraNameAlonzo,
+}
 
 func init() {
 	common.RegisterEra(EraAlonzo)
@@ -169,7 +166,6 @@ func (b *AlonzoTransactionBody) UnmarshalCBOR(cborData []byte) error {
 func (b *AlonzoTransactionBody) Outputs() []common.TransactionOutput {
 	ret := []common.TransactionOutput{}
 	for _, output := range b.TxOutputs {
-
 		ret = append(ret, &output)
 	}
 	return ret
@@ -277,7 +273,7 @@ func (o AlonzoTransactionOutput) Utxorpc() *utxorpc.TxOutput {
 	if o.Assets() != nil {
 		tmpAssets := o.Assets()
 		for _, policyId := range tmpAssets.Policies() {
-			var ma = &utxorpc.Multiasset{
+			ma := &utxorpc.Multiasset{
 				PolicyId: policyId.Bytes(),
 			}
 			for _, assetName := range tmpAssets.Assets(policyId) {

ledger/alonzo/pparams.go

@@ -17,11 +17,10 @@ package alonzo
 import (
 	"math"
 
-	cardano "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
-
 	"github.com/blinklabs-io/gouroboros/cbor"
 	"github.com/blinklabs-io/gouroboros/ledger/common"
 	"github.com/blinklabs-io/gouroboros/ledger/mary"
+	cardano "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
 )
 
 type AlonzoProtocolParameters struct {

ledger/babbage.go

@@ -20,14 +20,16 @@ import "github.com/blinklabs-io/gouroboros/ledger/babbage"
 // to keep existing code working after a refactor of the ledger package
 
 // Babbage types
-type BabbageBlock = babbage.BabbageBlock
-type BabbageBlockHeader = babbage.BabbageBlockHeader
-type BabbageTransaction = babbage.BabbageTransaction
-type BabbageTransactionBody = babbage.BabbageTransactionBody
-type BabbageTransactionOutput = babbage.BabbageTransactionOutput
-type BabbageTransactionWitnessSet = babbage.BabbageTransactionWitnessSet
-type BabbageProtocolParameters = babbage.BabbageProtocolParameters
-type BabbageProtocolParameterUpdate = babbage.BabbageProtocolParameterUpdate
+type (
+	BabbageBlock                   = babbage.BabbageBlock
+	BabbageBlockHeader             = babbage.BabbageBlockHeader
+	BabbageTransaction             = babbage.BabbageTransaction
+	BabbageTransactionBody         = babbage.BabbageTransactionBody
+	BabbageTransactionOutput       = babbage.BabbageTransactionOutput
+	BabbageTransactionWitnessSet   = babbage.BabbageTransactionWitnessSet
+	BabbageProtocolParameters      = babbage.BabbageProtocolParameters
+	BabbageProtocolParameterUpdate = babbage.BabbageProtocolParameterUpdate
+)
 
 // Babbage constants
 const (

ledger/babbage/babbage.go

@@ -25,7 +25,6 @@ import (
 	"github.com/blinklabs-io/gouroboros/ledger/common"
 	"github.com/blinklabs-io/gouroboros/ledger/mary"
 	"github.com/blinklabs-io/gouroboros/ledger/shelley"
-
 	utxorpc "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
 )
 
@@ -40,12 +39,10 @@ const (
 	TxTypeBabbage = 5
 )
 
-var (
-	EraBabbage = common.Era{
-		Id:   EraIdBabbage,
-		Name: EraNameBabbage,
-	}
-)
+var EraBabbage = common.Era{
+	Id:   EraIdBabbage,
+	Name: EraNameBabbage,
+}
 
 func init() {
 	common.RegisterEra(EraBabbage)
@@ -228,7 +225,6 @@ func (b *BabbageTransactionBody) UnmarshalCBOR(cborData []byte) error {
 func (b *BabbageTransactionBody) Outputs() []common.TransactionOutput {
 	ret := []common.TransactionOutput{}
 	for _, output := range b.TxOutputs {
-
 		ret = append(ret, &output)
 	}
 	return ret
@@ -245,7 +241,6 @@ func (b *BabbageTransactionBody) ProtocolParameterUpdates() (uint64, map[common.
 func (b *BabbageTransactionBody) ReferenceInputs() []common.TransactionInput {
 	ret := []common.TransactionInput{}
 	for _, input := range b.TxReferenceInputs {
-
 		ret = append(ret, &input)
 	}
 	return ret
@@ -458,7 +453,7 @@ func (o BabbageTransactionOutput) Utxorpc() *utxorpc.TxOutput {
 	if o.Assets() != nil {
 		tmpAssets := o.Assets()
 		for _, policyId := range tmpAssets.Policies() {
-			var ma = &utxorpc.Multiasset{
+			ma := &utxorpc.Multiasset{
 				PolicyId: policyId.Bytes(),
 			}
 			for _, assetName := range tmpAssets.Assets(policyId) {

ledger/babbage/pparams.go

@@ -17,11 +17,10 @@ package babbage
 import (
 	"math"
 
-	cardano "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
-
 	"github.com/blinklabs-io/gouroboros/cbor"
 	"github.com/blinklabs-io/gouroboros/ledger/alonzo"
 	"github.com/blinklabs-io/gouroboros/ledger/common"
+	cardano "github.com/utxorpc/go-codegen/utxorpc/v1alpha/cardano"
 )
 
 // BabbageProtocolParameters represents the current Babbage protocol parameters as seen in local-state-query

ledger/babbage/rules.go

@@ -142,7 +142,8 @@ func UtxoValidateCollateralContainsNonAda(
 		}
 		totalCollateral += utxo.Output.Amount()
 		totalAssets.Add(utxo.Output.Assets())
-		if utxo.Output.Assets() == nil || len(utxo.Output.Assets().Policies()) == 0 {
+		if utxo.Output.Assets() == nil ||
+			len(utxo.Output.Assets().Policies()) == 0 {
 			continue
 		}
 		badOutputs = append(badOutputs, utxo.Output)

ledger/babbage/rules_test.go

@@ -1113,14 +1113,14 @@ func TestUtxoValidateCollateralContainsNonAda(t *testing.T) {
 	}
 	tmpMultiAsset := common.NewMultiAsset[common.MultiAssetTypeOutput](
 		map[common.Blake2b224]map[cbor.ByteString]uint64{
-			common.Blake2b224Hash([]byte("abcd")): map[cbor.ByteString]uint64{
+			common.Blake2b224Hash([]byte("abcd")): {
 				cbor.NewByteString([]byte("efgh")): 123,
 			},
 		},
 	)
 	tmpZeroMultiAsset := common.NewMultiAsset[common.MultiAssetTypeOutput](
 		map[common.Blake2b224]map[cbor.ByteString]uint64{
-			common.Blake2b224Hash([]byte("abcd")): map[cbor.ByteString]uint64{
+			common.Blake2b224Hash([]byte("abcd")): {
 				cbor.NewByteString([]byte("efgh")): 0,
 			},
 		},

ledger/block.go

@@ -22,8 +22,10 @@ import (
 )
 
 // Compatibility aliases
-type Block = common.Block
-type BlockHeader = common.BlockHeader
+type (
+	Block       = common.Block
+	BlockHeader = common.BlockHeader
+)
 
 func NewBlockFromCbor(blockType uint, data []byte) (Block, error) {
 	switch blockType {