fix(genesis): Added json labels to all genesis structs #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akhil Repala <[email protected]>
agaffney
requested changes
Mar 24, 2025
ledger/common/genesis.go
Outdated
| // GenesisRat is a wrapper to big.Rat that allows for unmarshaling from a bare float from JSON | ||
| type GenesisRat struct { | ||
| *big.Rat | ||
| *big.Rat `json:"string"` |
There was a problem hiding this comment.
This is "wrong" and probably not effective in any meaningful way. This field is an embedded struct, and the GenesisRat type has custom UnmarshalJSON and MarshalJSON functions
There was a problem hiding this comment.
I have removed it and tested again. Please review it once
…enesisRat Signed-off-by: Akhil Repala <[email protected]>
agaffney
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #926