Skip to content

feat(ledger): Add a method to get the Certificate type to the interface #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

feat(ledger): Add a method to get the Certificate type to the interface #971

merged 2 commits into from
Mar 31, 2025

Conversation

arepala-uml
Copy link
Contributor

@arepala-uml arepala-uml commented Mar 30, 2025 •
edited by wolf31o2
Loading

  1. Added a new Type() uint method to the Certificate interface.
  2. Added this method for all 19 certificate types using the existing CertType field.
  3. Added a test function to validate the method Type() returns the expected values.

Closes #636

@arepala-uml arepala-uml marked this pull request as ready for review March 30, 2025 01:07
@arepala-uml arepala-uml requested a review from a team as a code owner March 30, 2025 01:07
wolf31o2
wolf31o2 requested changes Mar 30, 2025
View reviewed changes
Copy link
Member

@wolf31o2 wolf31o2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a negative test case, too. It doesn't need to fit into the existing loop. Let's ensure we're throwing an error correctly when they do not match.

@arepala-uml arepala-uml requested a review from wolf31o2 March 31, 2025 17:41
@wolf31o2 wolf31o2 changed the title Add a method to get the Certificate type to the interface feat(ledger): Add a method to get the Certificate type to the interface Mar 31, 2025
@wolf31o2 wolf31o2 merged commit 88272fb into main Mar 31, 2025
9 checks passed
@wolf31o2 wolf31o2 deleted the certificate_type branch March 31, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolf31o2 wolf31o2 wolf31o2 approved these changes

@agaffney agaffney Awaiting requested review from agaffney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a method to get the Certificate type to the interface
2 participants
@arepala-uml @wolf31o2