Skip to content

feat(ledger): Add Byron transaction output support to NewTransactionOutputFromCbor #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

feat(ledger): Add Byron transaction output support to NewTransactionOutputFromCbor #993

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5e78fc
feat(ledger): added Byron transaction output decoding support in tran…
arepala-uml Apr 17, 2025
f7369ee
feat(ledger): remove success logging from testcase function
arepala-uml Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ledger/byron.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,5 @@ var (
NewByronMainBlockHeaderFromCbor = byron.NewByronMainBlockHeaderFromCbor
NewByronTransactionInput = byron.NewByronTransactionInput
NewByronTransactionFromCbor = byron.NewByronTransactionFromCbor
NewByronTransactionOutputFromCbor = byron.NewByronTransactionOutputFromCbor
)
8 changes: 8 additions & 0 deletions ledger/byron/byron.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -771,3 +771,11 @@ func NewByronTransactionFromCbor(data []byte) (*ByronTransaction, error) {
}
return &byronTx, nil
}

func NewByronTransactionOutputFromCbor(data []byte) (*ByronTransactionOutput, error) {
var byronTxOutput ByronTransactionOutput
if _, err := cbor.Decode(data, &byronTxOutput); err != nil {
return nil, fmt.Errorf("decode Byron transaction output error: %w", err)
}
return &byronTxOutput, nil
}
14 changes: 6 additions & 8 deletions ledger/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ func NewTransactionBodyFromCbor(
// NewTransactionOutputFromCbor attempts to parse the provided arbitrary CBOR data as a transaction output from
// each of the eras, returning the first one that we can successfully decode
func NewTransactionOutputFromCbor(data []byte) (TransactionOutput, error) {
// TODO: add Byron transaction output support (#849)
if txOut, err := NewByronTransactionOutputFromCbor(data); err == nil {
return txOut, nil
}
if txOut, err := NewShelleyTransactionOutputFromCbor(data); err == nil {
return txOut, nil
}
Expand All @@ -93,13 +95,9 @@ func NewTransactionOutputFromCbor(data []byte) (TransactionOutput, error) {
}

func DetermineTransactionType(data []byte) (uint, error) {
// TODO: uncomment this once the following issue is resolved: (#849)
// https://github.com/blinklabs-io/gouroboros/issues/206
/*
if _, err := NewByronTransactionFromCbor(data); err == nil {
return TxTypeByron, nil
}
*/
if _, err := NewByronTransactionFromCbor(data); err == nil {
return TxTypeByron, nil
}
if _, err := NewShelleyTransactionFromCbor(data); err == nil {
return TxTypeShelley, nil
}
Expand Down
10 changes: 9 additions & 1 deletion ledger/tx_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,20 @@ import (

func TestDetermineTransactionType(t *testing.T) {
testDefs := []struct {
name string
txCborHex string
expectedTxType uint
}{
{
name: "ConwayTx",
txCborHex: "84a500d9010281825820279184037d249e397d97293738370756da559718fcdefae9924834840046b37b01018282583900923d4b64e1d730a4baf3e6dc433a9686983940f458363f37aad7a1a9568b72f85522e4a17d44a45cd021b9741b55d7cbc635c911625b015e1a00a9867082583900923d4b64e1d730a4baf3e6dc433a9686983940f458363f37aad7a1a9568b72f85522e4a17d44a45cd021b9741b55d7cbc635c911625b015e1b00000001267d7b04021a0002938d031a04e304e70800a100d9010281825820b829480e5d5827d2e1bd7c89176a5ca125c30812e54be7dbdf5c47c835a17f3d5840b13a76e7f2b19cde216fcad55ceeeb489ebab3dcf63ef1539ac4f535dece00411ee55c9b8188ef04b4aa3c72586e4a0ec9b89949367d7270fdddad3b18731403f5f6",
expectedTxType: 6,
},
{
name: "ByronTx",
txCborHex: "839f8200d8185824825820a12a839c25a01fa5d118167db5acdbd9e38172ae8f00e5ac0a4997ef792a200700ff9f8282d818584283581c6c9982e7f2b6dcc5eaa880e8014568913c8868d9f0f86eb687b2633ca101581e581c010d876783fb2b4d0d17c86df29af8d35356ed3d1827bf4744f06700001a8dc672c11a000f4240ffa0",
expectedTxType: 0,
},
}
for _, testDef := range testDefs {
txCbor, err := hex.DecodeString(testDef.txCborHex)
Expand All @@ -38,7 +45,7 @@ func TestDetermineTransactionType(t *testing.T) {
}
tmpTxType, err := ledger.DetermineTransactionType(txCbor)
if err != nil {
t.Fatalf("unexpected error: %s", err)
t.Fatalf("DetermineTransactionType failed with an unexpected error: %s", err)
}
if tmpTxType != testDef.expectedTxType {
t.Fatalf(
Expand All @@ -47,5 +54,6 @@ func TestDetermineTransactionType(t *testing.T) {
testDef.expectedTxType,
)
}
t.Logf("Test %s passed: correctly identified tx type %d", testDef.name, tmpTxType)
}
}
Loading