Skip to content

fix(submit): error check timeout input #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wolf31o2 merged 1 commit into from
Feb 23, 2025
Merged

fix(submit): error check timeout input #307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions submit/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package submit

import (
"fmt"
"math"
"time"

ouroboros "github.com/blinklabs-io/gouroboros"
Expand All @@ -34,6 +35,10 @@ type Config struct {
}

func SubmitTx(cfg *Config, txRawBytes []byte) (string, error) {
// Fail fast if timeout is too large
if cfg.Timeout > math.MaxInt64 {
return "", fmt.Errorf("given timeout too large")
}
// Determine transaction type (era)
txType, err := ledger.DetermineTransactionType(txRawBytes)
if err != nil {
Expand Down Expand Up @@ -82,6 +87,7 @@ func SubmitTx(cfg *Config, txRawBytes []byte) (string, error) {
oConn.Close()
}()
// Submit the transaction
// #nosec G115
if err := oConn.LocalTxSubmission().Client.SubmitTx(uint16(txType), txRawBytes); err != nil {
return "", fmt.Errorf("%s", err.Error())
}
Expand Down